On Tue, 2 Aug 2016 23:18:57 -0400 Steven Rostedt <rost...@goodmis.org> wrote:
> On Tue, 2 Aug 2016 22:12:33 -0500 > Josh Poimboeuf <jpoim...@redhat.com> wrote: > > > > Sounds good. I was thinking I could also add a similar define to > > indicate whether an arch passes the return address stack pointer to > > ftrace_push_return_trace(). HAVE_FUNCTION_GRAPH_RET_ADDR_PTR? > > > > If you are making this function global, might as well make all pass > that pointer when you do the conversion. I don't think we need a define > to differentiate it. > Bah, I was thinking of your ftrace_graph_ret_addr() function. /me needs to go to bed. Anyway, if we have to add a parameter, we probably need to update all the callers anyway. We do need to add a parameter for this, right? -- Steve
