On Fri, Aug 05, 2016 at 10:28:39AM -0500, Nilay Vaish wrote: > On 4 August 2016 at 17:21, Josh Poimboeuf <jpoim...@redhat.com> wrote: > > The 'stack_start' variable is similar in usage to 'initial_code' and > > 'initial_gs': they're all stored in head_64.S and they're all updated by > > SMP and ACPI suspend before starting a CPU. > > > > Rename it to 'initial_stack' to be consistent with the others. > > > > May be change the following line as well: > > ./arch/x86/kernel/head_64.S:69: * Setup stack for verify_cpu(). > "-8" because stack_start is defined
Ah, yeah, I missed that one. And also, now that I see that comment, and the line below it: leaq (__end_init_task - 8)(%rip), %rsp The 8 should be changed to SIZEOF_PTREGS in a later patch ("x86/asm/head: standardize the end of the stack for idle tasks"). -- Josh