On Thu 04 Aug 02:21 PDT 2016, Lee Jones wrote: > These types of error prints are superfluous. The system will > pick up on OOM issues and let the user know. > > Signed-off-by: Lee Jones <[email protected]>
Acked-by: Bjorn Andersson <[email protected]> Although, I think we should drop the "mapping" object. We have all the information in the carveout object to reverse the mapping at cleanup. Regards, Bjorn > --- > drivers/remoteproc/remoteproc_core.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/remoteproc/remoteproc_core.c > b/drivers/remoteproc/remoteproc_core.c > index 5654a81..4914482 100644 > --- a/drivers/remoteproc/remoteproc_core.c > +++ b/drivers/remoteproc/remoteproc_core.c > @@ -619,7 +619,6 @@ static int rproc_handle_carveout(struct rproc *rproc, > if (rproc->domain) { > mapping = kzalloc(sizeof(*mapping), GFP_KERNEL); > if (!mapping) { > - dev_err(dev, "kzalloc mapping failed\n"); > ret = -ENOMEM; > goto dma_free; > } > -- > 2.9.0 >
