On Tue, Aug 16, 2016 at 01:45:03PM -0700, J Freyensee wrote: > On Mon, 2016-08-15 at 22:41 -0300, Helen Koike wrote: > > struct nvmf_connect_command connect; > > struct nvmf_property_set_command prop_set; > > struct nvmf_property_get_command prop_get; > > + struct nvme_doorbell_memory doorbell_memory; > > }; > > }; > > This looks like a new NVMe command being introduced, not found in the > latest NVMe specs (NVMe 1.2.1 spec or NVMe-over-Fabrics 1.0 spec)? > > This is a big NACK, the command needs to be part of the NVMe standard > before adding it to the NVMe code base (this is exactly how NVMe-over- > Fabrics standard got implemented). I would bring your proposal to > nvmexpress.org.
While this is an approved TPAR up for consideration soon, I don't think we want to include this in mainline before it is ratified lest the current form conflicts with the future spec. We can still review and comment on the code, though it's not normally done publicly until the spec is also public. The proposal originated from a public RFC, though, so it's not a secret.
