I don't think we need to gate this based on the platform. If you look at the differences between what is done:
- The printk is no longer called. That's fine; we already did the printk modified in patch 2/2. The user is aware there machine doesn't have PCI :-) - We set the cacheline size. That's copying a value from the cpuinfo to a global __read_mostly variable and emitting a printk. No big deal. - In pcibios_resource_survey, we iterate over three empty lists, call e820_reserve_resources_late() (which is what we want!) and call ioapic_insert_resources() (which I rather think we want too) In short, not calling these functions is a bug. We just haven't noticed before now because PCI is so omnipresent. -----Original Message----- From: Konrad Rzeszutek Wilk [mailto:[email protected]] Sent: Friday, August 19, 2016 12:07 PM To: Matthew Wilcox <[email protected]> Cc: [email protected]; [email protected]; [email protected]; Matthew Wilcox <[email protected]> Subject: Re: [PATCH 1/2] x86: Set up resources correctly on Hyper-V Generation 2 On Thu, Aug 18, 2016 at 12:12:54PM -0700, Matthew Wilcox wrote: > @@ -516,11 +516,6 @@ void __init pcibios_set_cache_line_size(void) > > int __init pcibios_init(void) > { > - if (!raw_pci_ops && !raw_pci_ext_ops) { > - printk(KERN_WARNING "PCI: System does not support PCI\n"); > - return 0; > - } So shouldn't this be gated on whether the platform is HyperV? > - > pcibios_set_cache_line_size(); > pcibios_resource_survey(); > > -- > 2.8.1 > > _______________________________________________ > Linux-nvdimm mailing list > [email protected] > https://lists.01.org/mailman/listinfo/linux-nvdimm
