On Wed, Feb 14, 2007 at 10:02:04AM +0000, Mark Brown wrote:

> Signed-Off-By: Mark Brown <[EMAIL PROTECTED]>
> 
[...]
> -             if (np->phy_addr_external == PHY_ADDR_NONE) {
> +             /* If we're ignoring the PHY it doesn't matter if we can't
> +              * find one. */
> +             if (!np->ignore_phy && np->phy_addr_external == PHY_ADDR_NONE) {
[...]
> +     if (!np->ignore_phy) {
> +             /* The link status field is latched: it remains low
> +              * after a temporary link failure until it's read. We
> +              * need the current link status, thus read twice.
> +              */
> +             mdio_read(dev, MII_BMSR);
> +             bmsr = mdio_read(dev, MII_BMSR);
[...]
>       /*
> +      * If we're ignoring the PHY then autoneg and the internal
> +      * transciever are really not going to work so don't let the
> +      * user select them.
> +      */
> +     if (np->ignore_phy && (ecmd->autoneg == AUTONEG_ENABLE ||

A trivial comment actually, Is there a point to write multi-line comments 
in two different formats ?

Thanks,

-- 
Ahmed S. Darwish
http://darwish-07.blogspot.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to