schedule_timeout_* takes a timeout in jiffies but the code currently is passing in a constant which makes this timeout HZ dependent, so pass it through msecs_to_jiffies() to fix this up.
Signed-off-by: Nicholas Mc Guire <hof...@osadl.org> --- Problem found by coccinelle script The below patch sets the timeout to 50ms - not clear what HZ setting was assumed during design/testing, so this needs an ack by someone who knows the driver and can confirm that 50ms is reasonable to wait on retries. Patch was compile tested with: x86_64_defconfig + CONFIG_NTB=m, CONFIG_NTB_TRANSPORT=m Patch is against 4.8.0-rc2 (localversion-next is -next-20160822) drivers/ntb/ntb_transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c index 8601c10..4eb8adb 100644 --- a/drivers/ntb/ntb_transport.c +++ b/drivers/ntb/ntb_transport.c @@ -257,7 +257,7 @@ enum { #define NTB_QP_DEF_NUM_ENTRIES 100 #define NTB_LINK_DOWN_TIMEOUT 10 #define DMA_RETRIES 20 -#define DMA_OUT_RESOURCE_TO 50 +#define DMA_OUT_RESOURCE_TO msecs_to_jiffies(50) static void ntb_transport_rxc_db(unsigned long data); static const struct ntb_ctx_ops ntb_transport_ops; -- 2.1.4