Miklos Szeredi <[email protected]> wrote:

> This is trivial to do:
> 
>  - add flags argument to foo_rename()
>  - check if flags is zero
>  - assign foo_rename() to .rename2 instead of .rename
> 
> This doesn't mean it's impossible to support RENAME_NOREPLACE for these
> filesystems, but it is not trivial, like for local filesystems.
> RENAME_NOREPLACE must guarantee atomicity (i.e. it shouldn't be possible
> for a file to be created on one host while it is overwritten by rename on
> another host).
> 
> Filesystems converted:
> 
> 9p, afs, ceph, coda, ecryptfs, exofs, kernfs, lustre, ncpfs, nfs, ocfs2,
> orangefs.
> 
> After this, we can get rid of the duplicate interfaces for rename.
> 
> Signed-off-by: Miklos Szeredi <[email protected]>
> Cc: Eric Van Hensbergen <[email protected]>
> Cc: Ilya Dryomov <[email protected]>
> Cc: Jan Harkes <[email protected]>
> Cc: Tyler Hicks <[email protected]>
> Cc: Boaz Harrosh <[email protected]>
> Cc: Greg Kroah-Hartman <[email protected]>
> Cc: Oleg Drokin <[email protected]>
> Cc: Trond Myklebust <[email protected]>
> Cc: Mark Fasheh <[email protected]>
> Cc: Mike Marshall <[email protected]>

Acked-by: David Howells <[email protected]> [AFS]

Reply via email to