Re: [PATCH 1/2] drivercore: Add helper macro for misc device boilerplate

[kbuild test robot]

Hi PrasannaKumar,

[auto build test WARNING on linus/master]
[also build test WARNING on v4.8-rc3 next-20160823]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]
[Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for 
convenience) to record what (public, well-known) commit your patch series was 
built on]
[Check https://git-scm.com/docs/git-format-patch for more information]

url:    
https://github.com/0day-ci/linux/commits/PrasannaKumar-Muralidharan/drivercore-Add-helper-macro-for-misc-device-boilerplate/20160821-151236
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 5.4.0-6) 5.4.0 20160609
reproduce:
        wget 
https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross
 -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

All warnings (new ones prefixed by >>):

   In file included from arch/arm/common/bL_switcher_dummy_if.c:17:0:
   include/linux/miscdevice.h:78:2: warning: data definition has no type or 
storage class
     module_driver(__misc_device, misc_register, misc_deregister)
     ^
>> arch/arm/common/bL_switcher_dummy_if.c:59:1: note: in expansion of macro 
>> 'module_misc_device'
    module_misc_device(bL_switcher_device);
    ^
   include/linux/miscdevice.h:78:2: error: type defaults to 'int' in 
declaration of 'module_driver' [-Werror=implicit-int]
     module_driver(__misc_device, misc_register, misc_deregister)
     ^
>> arch/arm/common/bL_switcher_dummy_if.c:59:1: note: in expansion of macro 
>> 'module_misc_device'
    module_misc_device(bL_switcher_device);
    ^
>> arch/arm/common/bL_switcher_dummy_if.c:59:1: warning: parameter names 
>> (without types) in function declaration
>> arch/arm/common/bL_switcher_dummy_if.c:54:26: warning: 'bL_switcher_device' 
>> defined but not used [-Wunused-variable]
    static struct miscdevice bL_switcher_device = {
                             ^
   cc1: some warnings being treated as errors

vim +/module_misc_device +59 arch/arm/common/bL_switcher_dummy_if.c

    11   * published by the Free Software Foundation.
    12   */
    13  
    14  #include <linux/init.h>
    15  #include <linux/module.h>
    16  #include <linux/fs.h>
  > 17  #include <linux/miscdevice.h>
    18  #include <asm/uaccess.h>
    19  #include <asm/bL_switcher.h>
    20  
    21  static ssize_t bL_switcher_write(struct file *file, const char __user 
*buf,
    22                          size_t len, loff_t *pos)
    23  {
    24          unsigned char val[3];
    25          unsigned int cpu, cluster;
    26          int ret;
    27  
    28          pr_debug("%s\n", __func__);
    29  
    30          if (len < 3)
    31                  return -EINVAL;
    32  
    33          if (copy_from_user(val, buf, 3))
    34                  return -EFAULT;
    35  
    36          /* format: <cpu#>,<cluster#> */
    37          if (val[0] < '0' || val[0] > '9' ||
    38              val[1] != ',' ||
    39              val[2] < '0' || val[2] > '1')
    40                  return -EINVAL;
    41  
    42          cpu = val[0] - '0';
    43          cluster = val[2] - '0';
    44          ret = bL_switch_request(cpu, cluster);
    45  
    46          return ret ? : len;
    47  }
    48  
    49  static const struct file_operations bL_switcher_fops = {
    50          .write          = bL_switcher_write,
    51          .owner  = THIS_MODULE,
    52  };
    53  
  > 54  static struct miscdevice bL_switcher_device = {
    55          MISC_DYNAMIC_MINOR,
    56          "b.L_switcher",
    57          &bL_switcher_fops
    58  };
  > 59  module_misc_device(bL_switcher_device);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

.config.gz
Description: Binary data