HI Andrew, 2016-08-23 16:16 GMT+02:00 Andrew Lunn <and...@lunn.ch>: > On Tue, Aug 23, 2016 at 08:26:48AM +0200, Marcin Wojtas wrote: >> Armada CP110 system controller comprise its own routine responsble >> for registering gate clocks. Among others 'flags' field in >> struct clk_init_data was not set, using a random values, which >> may cause an unpredicted behavior. >> >> This patch fixes the problem by setting CLK_IS_BASIC flag for >> all gated clocks of Armada 7k/8k SoCs family. >> >> Fixes: d3da3eaef7f4 ("clk: mvebu: new driver for Armada CP110 system ...") >> >> Signed-off-by: Marcin Wojtas <m...@semihalf.com> >> --- >> drivers/clk/mvebu/cp110-system-controller.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/clk/mvebu/cp110-system-controller.c >> b/drivers/clk/mvebu/cp110-system-controller.c >> index 7fa42d6..0835e1d 100644 >> --- a/drivers/clk/mvebu/cp110-system-controller.c >> +++ b/drivers/clk/mvebu/cp110-system-controller.c >> @@ -144,6 +144,7 @@ static struct clk *cp110_register_gate(const char *name, >> >> init.name = name; >> init.ops = &cp110_gate_ops; >> + init.flags = CLK_IS_BASIC; >> init.parent_names = &parent_name; >> init.num_parents = 1; > > Hi Marcin > > How about adding a memset for init? That would also help if new fields > every get added to clk_init_data. >
Sure, it can be added. Best regards, Marcin