On Tue, Aug 23, 2016 at 10:32 PM, Chris Wilson <ch...@chris-wilson.co.uk> wrote:
> The io-mapping.h include arose from the need to workaround an arch/um > compile failure: > > drivers/gpio/gpio-mpc8xxx.c: In function 'mpc8xxx_probe': >>> drivers/gpio/gpio-mpc8xxx.c:373:2: error: implicit declaration of >>> function 'iounmap' [-Werror=implicit-function-declaration] > iounmap(mpc8xxx_gc->regs); > ^~~~~~~ > > from commit 296ad4acb8ef ("gpio: remove deps on > ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") but io-mapping.h doesn't provide > iounmap so the problem persisted and eventually (will be) silenced by > making OF_GPIO depend on !NO_IOMEM (i.e. disabling building under > arch/um). My desire to remove the unneed include to io-mapping is to > simplify verification of changes to io-mapping.h > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > Cc: Linus Walleij <linus.wall...@linaro.org> > Cc: Alexandre Courbot <gnu...@gmail.com> > Cc: linux-g...@vger.kernel.org I chose to to a proper revert instead, but I have added your for Reported-by: Thanks a lot. Yours, Linus Walleij