On Thu, Aug 25, 2016 at 12:54:00AM -0700, Andy Lutomirski wrote: > I am, and I have a patch to do the former (and to add a length > argument). But that's not -stable material.
Great! > While I have your attention: the new use is to enable APST (power > saving). In theory, it seems like I should integrate with dev_pm_qos > so that the standard interface for setting a latency limit will work, > but, on brief inspection, there are literally no drivers in the entire > tree that do this. Am I missing something? My current draft patch > just adds a sysfs attribute. (It saves a *lot* of power on my laptop, > so supporting APST is worth doing.) I'm proably the wrong person to talk about PM interfaces, but not having it used anywhere is a red herring and needs a ping to the PM folks why we even have that code in the tree. Integrating it with the PM core would be preferable, but until that happens we should just enable it by default in the nvme driver and have a local tweak (sysfs file, or maybe even just a run-time writeable module parameter) to turn it off.
