This patch could reduce one branch in this function. Also
make the code more readble.
Signed-off-by: Alex Shi <alex....@linaro.org>
Acked-by: Daniel Lezcano <daniel.lezc...@linaro.org>
To: linux-kernel@vger.kernel.org
To: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Cc: linux...@vger.kernel.org
Cc: Ulf Hansson <ulf.hans...@linaro.org>
Cc: Daniel Lezcano <daniel.lezc...@linaro.org>
---
drivers/base/cpu.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c
index 691eeea..4c28e1a 100644
--- a/drivers/base/cpu.c
+++ b/drivers/base/cpu.c
@@ -371,12 +371,13 @@ int register_cpu(struct cpu *cpu, int num)
if (cpu->hotpluggable)
cpu->dev.groups = hotplugable_cpu_attr_groups;
error = device_register(&cpu->dev);
- if (!error)
- per_cpu(cpu_sys_devices, num) = &cpu->dev;
- if (!error)
- register_cpu_under_node(num, cpu_to_node(num));
+ if (error)
+ return error;
- return error;
+ per_cpu(cpu_sys_devices, num) = &cpu->dev;
+ register_cpu_under_node(num, cpu_to_node(num));
+
+ return 0;
}
struct device *get_cpu_device(unsigned cpu)
--
2.8.1.101.g72d917a
