On 29/08/16 16:18, Linus Walleij wrote: > On Fri, Aug 26, 2016 at 5:25 PM, Arnd Bergmann <[email protected]> wrote: > > [I don't see why Torvalds was CC'ed on this patch? Was there > some specific complaint from his side that I screw things up > or just the wrong Linus?] > >> The addition of the Nomadik support in this driver introduced >> a bug in clcdfb_of_init_display(), which now calls init_panel >> with an uninitialized 'endpoint' pointer, as "gcc -Wmaybe-uninitialized" >> warns: >> >> drivers/video/fbdev/amba-clcd.c: In function 'clcdfb_of_init_display': >> drivers/video/fbdev/amba-clcd.c:785:5: error: 'endpoint' may be used >> uninitialized in this function [-Werror=maybe-uninitialized] >> >> This reverts the broken part of the function to what it was before >> the patch, which is the best guess I have to what it should be. >> I assume this was left over from an attempted rework of the >> code that was partially backed out. >> >> Signed-off-by: Arnd Bergmann <[email protected]> >> Fixes: 046ad6cdeb3f ("video: ARM CLCD: support Nomadik variant") >> Cc: Linus Walleij <[email protected]> > > Reviewed-by: Linus Walleij <[email protected]> > > Tomi: I think this bug was also reported by Ian King, so suggest > adding his > Reported-by: Colin Ian King <[email protected]> >
Thanks, queued for v4.9. Tomi
signature.asc
Description: OpenPGP digital signature
