Commit-ID:  0c228919e04ddec195402296e7ebf2472ed6caef
Gitweb:     http://git.kernel.org/tip/0c228919e04ddec195402296e7ebf2472ed6caef
Author:     Sebastian Frias <s...@laposte.net>
AuthorDate: Tue, 2 Aug 2016 10:52:45 +0200
Committer:  Thomas Gleixner <t...@linutronix.de>
CommitDate: Fri, 2 Sep 2016 18:06:50 +0200

irqdomain: Mask irq type in irq_domain_xlate_onetwocell()

According to the xlate() callback definition, the 'out_type' parameter
needs to be the "linux irq type".

A mask for such bits exists, IRQ_TYPE_SENSE_MASK, which is correctly
applied in irq_domain_xlate_twocell()

So use it for irq_domain_xlate_onetwocell() as well.

Signed-off-by: Sebastian Frias <s...@laposte.net>
Cc: Grant Likely <grant.lik...@secretlab.ca>
Cc: Marc Zyngier <marc.zyng...@arm.com>
Cc: Mason <slash....@free.fr>
Cc: Jason Cooper <ja...@lakedaemon.net>
Link: http://lkml.kernel.org/r/57a05f5d....@laposte.net
Signed-off-by: Thomas Gleixner <t...@linutronix.de>

---
 kernel/irq/irqdomain.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
index 4752b43..f10cffe 100644
--- a/kernel/irq/irqdomain.c
+++ b/kernel/irq/irqdomain.c
@@ -868,7 +868,10 @@ int irq_domain_xlate_onetwocell(struct irq_domain *d,
        if (WARN_ON(intsize < 1))
                return -EINVAL;
        *out_hwirq = intspec[0];
-       *out_type = (intsize > 1) ? intspec[1] : IRQ_TYPE_NONE;
+       if (intsize > 1)
+               *out_type = intspec[1] & IRQ_TYPE_SENSE_MASK;
+       else
+               *out_type = IRQ_TYPE_NONE;
        return 0;
 }
 EXPORT_SYMBOL_GPL(irq_domain_xlate_onetwocell);

Reply via email to