Hi Paul, The driver looks fine to me, just two notes:
On Fri, Sep 02, 2016 at 04:48:57PM +0100, Paul Burton wrote: > Add a driver which allows powering off the system via an Intel PIIX4 > southbridge, by entering the PIIX4 SOff state. This is useful on the > MIPS Malta development board, where it will power down the FPGA based > board until its ON/NMI button is pressed, or the QEMU implementation of > the MIPS Malta board where it will cause QEMU to exit. > > Signed-off-by: Paul Burton <[email protected]> > --- > > drivers/power/reset/Kconfig | 9 +++ > drivers/power/reset/Makefile | 1 + > drivers/power/reset/piix4-poweroff.c | 103 > +++++++++++++++++++++++++++++++++++ > 3 files changed, 113 insertions(+) > create mode 100644 drivers/power/reset/piix4-poweroff.c > > diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig > index c74c3f6..b27ca50 100644 > --- a/drivers/power/reset/Kconfig > +++ b/drivers/power/reset/Kconfig > @@ -104,6 +104,15 @@ config POWER_RESET_MSM > help > Power off and restart support for Qualcomm boards. > > +config POWER_RESET_PIIX4_POWEROFF > + tristate "Intel PIIX4 power-off driver" > + depends on MIPS && PCI depends on PCI depends on MIPS || COMPILE_TEST > + help > + This driver supports powering off a system using the Intel PIIX4 > + southbridge, for example the MIPS Malta development board. The > + southbridge SOff state is entered in response to a request to > + power off the system. > + > config POWER_RESET_LTC2952 > bool "LTC2952 PowerPath power-off driver" > depends on OF_GPIO > diff --git a/drivers/power/reset/Makefile b/drivers/power/reset/Makefile > index 1be307c..11dae3b 100644 > --- a/drivers/power/reset/Makefile > +++ b/drivers/power/reset/Makefile > @@ -10,6 +10,7 @@ obj-$(CONFIG_POWER_RESET_GPIO_RESTART) += gpio-restart.o > obj-$(CONFIG_POWER_RESET_HISI) += hisi-reboot.o > obj-$(CONFIG_POWER_RESET_IMX) += imx-snvs-poweroff.o > obj-$(CONFIG_POWER_RESET_MSM) += msm-poweroff.o > +obj-$(CONFIG_POWER_RESET_PIIX4_POWEROFF) += piix4-poweroff.o > obj-$(CONFIG_POWER_RESET_LTC2952) += ltc2952-poweroff.o > obj-$(CONFIG_POWER_RESET_QNAP) += qnap-poweroff.o > obj-$(CONFIG_POWER_RESET_RESTART) += restart-poweroff.o > diff --git a/drivers/power/reset/piix4-poweroff.c > b/drivers/power/reset/piix4-poweroff.c > new file mode 100644 > index 0000000..bfa8bea > --- /dev/null > +++ b/drivers/power/reset/piix4-poweroff.c [...] > + > +module_pci_driver(piix4_poweroff_driver); > +MODULE_AUTHOR("Paul Burton <[email protected]>"); missing MODULE_LICENSE() -- Sebastian
signature.asc
Description: PGP signature
