The mxs_chan->chan_irq variable is guaranteed to never be NO_IRQ,
as it gets assigned the result of platform_get_irq() that returns
either a valid positive interrupt number, or a negative failure
code that leads to the channel not being used.

This removes the redundant check, eliminating one more instance
of NO_IRQ.

Signed-off-by: Arnd Bergmann <a...@arndb.de>
---
 drivers/dma/mxs-dma.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/dma/mxs-dma.c b/drivers/dma/mxs-dma.c
index 50e64e113ffb..e217268c7098 100644
--- a/drivers/dma/mxs-dma.c
+++ b/drivers/dma/mxs-dma.c
@@ -428,12 +428,10 @@ static int mxs_dma_alloc_chan_resources(struct dma_chan 
*chan)
                goto err_alloc;
        }
 
-       if (mxs_chan->chan_irq != NO_IRQ) {
-               ret = request_irq(mxs_chan->chan_irq, mxs_dma_int_handler,
-                                       0, "mxs-dma", mxs_dma);
-               if (ret)
-                       goto err_irq;
-       }
+       ret = request_irq(mxs_chan->chan_irq, mxs_dma_int_handler,
+                         0, "mxs-dma", mxs_dma);
+       if (ret)
+               goto err_irq;
 
        ret = clk_prepare_enable(mxs_dma->clk);
        if (ret)
-- 
2.9.0

Reply via email to