Commit-ID:  712251665c8b6ff95fd27876338c2543d8fb5bc8
Gitweb:     http://git.kernel.org/tip/712251665c8b6ff95fd27876338c2543d8fb5bc8
Author:     Sebastian Andrzej Siewior <[email protected]>
AuthorDate: Thu, 18 Aug 2016 14:57:31 +0200
Committer:  Thomas Gleixner <[email protected]>
CommitDate: Tue, 6 Sep 2016 16:20:33 +0200

powerpc/mmu nohash: Convert to hotplug state machine

Install the callbacks via the state machine.

Signed-off-by: Sebastian Andrzej Siewior <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Benjamin Herrenschmidt <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: [email protected]
Cc: Michael Ellerman <[email protected]>
Cc: [email protected]
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Thomas Gleixner <[email protected]>

---
 arch/powerpc/mm/mmu_context_nohash.c | 56 ++++++++++++++++--------------------
 include/linux/cpuhotplug.h           |  1 +
 2 files changed, 25 insertions(+), 32 deletions(-)

diff --git a/arch/powerpc/mm/mmu_context_nohash.c 
b/arch/powerpc/mm/mmu_context_nohash.c
index 7d95bc4..522c2d3 100644
--- a/arch/powerpc/mm/mmu_context_nohash.c
+++ b/arch/powerpc/mm/mmu_context_nohash.c
@@ -369,44 +369,34 @@ void destroy_context(struct mm_struct *mm)
 }
 
 #ifdef CONFIG_SMP
-
-static int mmu_context_cpu_notify(struct notifier_block *self,
-                                 unsigned long action, void *hcpu)
+static int mmu_ctx_cpu_prepare(unsigned int cpu)
 {
-       unsigned int cpu = (unsigned int)(long)hcpu;
-
        /* We don't touch CPU 0 map, it's allocated at aboot and kept
         * around forever
         */
        if (cpu == boot_cpuid)
-               return NOTIFY_OK;
-
-       switch (action) {
-       case CPU_UP_PREPARE:
-       case CPU_UP_PREPARE_FROZEN:
-               pr_devel("MMU: Allocating stale context map for CPU %d\n", cpu);
-               stale_map[cpu] = kzalloc(CTX_MAP_SIZE, GFP_KERNEL);
-               break;
-#ifdef CONFIG_HOTPLUG_CPU
-       case CPU_UP_CANCELED:
-       case CPU_UP_CANCELED_FROZEN:
-       case CPU_DEAD:
-       case CPU_DEAD_FROZEN:
-               pr_devel("MMU: Freeing stale context map for CPU %d\n", cpu);
-               kfree(stale_map[cpu]);
-               stale_map[cpu] = NULL;
-
-               /* We also clear the cpu_vm_mask bits of CPUs going away */
-               clear_tasks_mm_cpumask(cpu);
-       break;
-#endif /* CONFIG_HOTPLUG_CPU */
-       }
-       return NOTIFY_OK;
+               return 0;
+
+       pr_devel("MMU: Allocating stale context map for CPU %d\n", cpu);
+       stale_map[cpu] = kzalloc(CTX_MAP_SIZE, GFP_KERNEL);
+       return 0;
 }
 
-static struct notifier_block mmu_context_cpu_nb = {
-       .notifier_call  = mmu_context_cpu_notify,
-};
+static int mmu_ctx_cpu_dead(unsigned int cpu)
+{
+#ifdef CONFIG_HOTPLUG_CPU
+       if (cpu == boot_cpuid)
+               return 0;
+
+       pr_devel("MMU: Freeing stale context map for CPU %d\n", cpu);
+       kfree(stale_map[cpu]);
+       stale_map[cpu] = NULL;
+
+       /* We also clear the cpu_vm_mask bits of CPUs going away */
+       clear_tasks_mm_cpumask(cpu);
+#endif
+       return 0;
+}
 
 #endif /* CONFIG_SMP */
 
@@ -469,7 +459,9 @@ void __init mmu_context_init(void)
 #else
        stale_map[boot_cpuid] = memblock_virt_alloc(CTX_MAP_SIZE, 0);
 
-       register_cpu_notifier(&mmu_context_cpu_nb);
+       cpuhp_setup_state_nocalls(CPUHP_POWER_MMU_CTX_PREPARE,
+                                 "powerpc/mmu/ctx:prepare",
+                                 mmu_ctx_cpu_prepare, mmu_ctx_cpu_dead);
 #endif
 
        printk(KERN_INFO
diff --git a/include/linux/cpuhotplug.h b/include/linux/cpuhotplug.h
index 84d1f0e..9d8bc0b 100644
--- a/include/linux/cpuhotplug.h
+++ b/include/linux/cpuhotplug.h
@@ -31,6 +31,7 @@ enum cpuhp_state {
        CPUHP_MD_RAID5_PREPARE,
        CPUHP_CPUIDLE_COUPLED_PREPARE,
        CPUHP_POWER_PMAC_PREPARE,
+       CPUHP_POWER_MMU_CTX_PREPARE,
        CPUHP_NOTIFY_PREPARE,
        CPUHP_TIMERS_DEAD,
        CPUHP_BRINGUP_CPU,

Reply via email to