Hi Jacek, Thank you for your comments.
> -----Original Message----- > From: Jacek Anaszewski [mailto:[email protected]] > Sent: Wednesday, September 07, 2016 3:49 PM > To: Vadim Pasternak <[email protected]>; [email protected] > Cc: [email protected]; [email protected]; > [email protected]; > Michael Shych <[email protected]> > Subject: Re: [patch] leds: add driver for Mellanox systems leds > > Hi Vadim, > > On 09/07/2016 03:35 PM, [email protected] wrote: > > From: Vadim Pasternak <[email protected]> > > > > This makes it possible to create a set of LEDs for Mellanox systems: > > "msx6710", "msx6720", "msb7700", "msn2700", "msx1410", "msn2410", > > "msb7800", "msn2740", "msn2100". > > > > Driver obtains led devices according to system configuration, provided > > through system DMI data, like fan1:green, fan1:red and creates devices > > in > > form: "devicename:colour:function". > > > > led setting is controlled through on board CPLD Lattice device. > > For setting particular led off, solid, blink (blink requires > > ledtrig-timer module): > > echo 0 > /sys/class/leds/status\:green/brightness > > echo 1 > /sys/class/leds/status\:green/brightness > > echo timer > /sys/class/leds/status\:green/trigger > > > > Thanks for the update, will review it soon. > > One important detail - please update patch version each time you're sending a > new one, like [PATCH v2]. > Will do it in this format next time. Thanks for this input. Best regards, Vadim. > -- > Best regards, > Jacek Anaszewski
