On Wed, 7 Sep 2016 09:37:00 -0700
Randy Dunlap <rdun...@infradead.org> wrote:
> On 09/07/16 00:52, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20160906:
> >
>
> on i386:
>
> ../kernel/trace/trace_hwlat.c: In function 'get_sample':
> ../kernel/trace/trace_hwlat.c:258:18: error: 'struct trace_array' has no
> member named 'max_latency'
> if (sample > tr->max_latency)
> ^
> ../kernel/trace/trace_hwlat.c:259:6: error: 'struct trace_array' has no
> member named 'max_latency'
> tr->max_latency = sample;
> ^
> ../kernel/trace/trace_hwlat.c: In function 'hwlat_tracer_init':
> ../kernel/trace/trace_hwlat.c:583:4: error: 'struct trace_array' has no
> member named 'max_latency'
> tr->max_latency = 0;
> ^
>
> when CONFIG_TRACER_MAX_TRACE is not enabled.
>
Thanks!
Below is the fix. I'll have to add it.
-- Steve
diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index 72c07c2ffd79..d9000a81960e 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -224,6 +224,7 @@ config SCHED_TRACER
config HWLAT_TRACER
bool "Tracer to detect hardware latencies (like SMIs)"
select GENERIC_TRACER
+ select TRACER_MAX_TRACE
help
This tracer, when enabled will create one or more kernel threads,
depening on what the cpumask file is set to, which each thread
