From: Colin Ian King <[email protected]>

pvt->pci_tad is a NUM_CHANNELS array of struct pci_dev pointers and
hence cannot be null, so the pull pointer check on pci_tad is
redundant.  Remove it.

Signed-off-by: Colin Ian King <[email protected]>
---
 drivers/edac/sb_edac.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
index ce0067b..5477522 100644
--- a/drivers/edac/sb_edac.c
+++ b/drivers/edac/sb_edac.c
@@ -2474,7 +2474,7 @@ static int sbridge_mci_bind_devs(struct mem_ctl_info *mci,
 
        /* Check if everything were registered */
        if (!pvt->pci_sad0 || !pvt->pci_sad1 || !pvt->pci_ha0 ||
-           !pvt-> pci_tad || !pvt->pci_ras  || !pvt->pci_ta)
+           !pvt->pci_ras || !pvt->pci_ta)
                goto enodev;
 
        if (saw_chan_mask != 0x0f)
@@ -2563,8 +2563,7 @@ static int ibridge_mci_bind_devs(struct mem_ctl_info *mci,
 
        /* Check if everything were registered */
        if (!pvt->pci_sad0 || !pvt->pci_ha0 || !pvt->pci_br0 ||
-           !pvt->pci_br1 || !pvt->pci_tad || !pvt->pci_ras  ||
-           !pvt->pci_ta)
+           !pvt->pci_br1 || !pvt->pci_ras || !pvt->pci_ta)
                goto enodev;
 
        if (saw_chan_mask != 0x0f && /* -EN */
-- 
2.9.3

Reply via email to