On Thu, Sep 08, 2016 at 01:24:02PM +0300, Mika Westerberg wrote: > On Thu, Sep 08, 2016 at 06:13:03PM +0800, Phidias Chiang wrote: > > On Thu, Aug 18, 2016 at 04:58:13PM +0300, Mika Westerberg wrote: > > > On Thu, Aug 18, 2016 at 03:52:57PM +0200, Anisse Astier wrote: > > > > On Thu, Aug 18, 2016 at 2:13 PM, Mika Westerberg > > > > <mika.westerb...@linux.intel.com> wrote: > > > > > On Wed, Aug 17, 2016 at 03:42:58PM +0200, Anisse Astier wrote: > > > > >> pin 25 (GPIO_SUS6) GPIO ctrl0 0xec918201 ctrl1 0x05c00001 > > > > > > > > > > It is this one (GPIO_SUS6). > > > > > > > > > > I wonder if we can relax the driver so that it only masks pins which > > > > > are > > > > > not configured to generate interrupts by the BIOS. I quickly tried > > > > > following on one Braswell machine and it did not generate spurious > > > > > interrupts. > > > > > > > > > > Can you check if this works for you? > > > > > > > > I tried it, your patch is working. It gives the same result as not > > > > clearing the north community. I receive the ACPI events. > > > > > > OK, thanks for testing. > > > > > > I'll make a formal patch and submit it with you CC'd. Let's hope it will > > > not break anything :) > > > > Hi, we've also found this issue on HP X360, but both patches don't work > > with on it. > > > > My current workaround is to save INTMASK before clearing then restore > > it after, but I'm not sure if there's any side-effect by doing so. > > Did you try the latest patch here? > > https://patchwork.ozlabs.org/patch/661413/
yes, that, including another patch in this thread. I inserted some debug message and found out INTMASK was still cleared after `gpiochip_irqchip_add`, hope it helps.
