On Fri, Sep 9, 2016 at 9:58 PM, Linus Torvalds <[email protected]> wrote: > On Fri, Sep 9, 2016 at 12:37 PM, Miklos Szeredi <[email protected]> wrote: >> >> This fixes a regression caused by the last pull request. > > So why are you checking error numbers one by one? > > Why is an error not just always an error?
The issue is that not all errors should result in failure. That code tries to remove ACL from a directory, and there are several cases: 1) success: that's good obviously 2) error: no ACL was found: that's also good 3) error: ACL's are not supported by the filesystem: this is also good 4) error: ACL was there but we failed to remove it for some other reason: this is not good The patch adds handling of case 3. Thanks, Miklos
