On Mon, Sep 05, 2016 at 06:11:55AM +0800, Caesar Wang wrote: > Add the regulator properties that will be used to power on/off > the regulator. > > Signed-off-by: Caesar Wang <[email protected]> > Cc: Rob Herring <[email protected]> > Cc: Jiri Kosina <[email protected]> > Cc: [email protected] > --- > > Documentation/devicetree/bindings/input/hid-over-i2c.txt | 3 +++ > 1 file changed, 3 insertions(+)
I find this binding a bit questionable. The compatible should describe the actual device, not just the protocol it uses. > diff --git a/Documentation/devicetree/bindings/input/hid-over-i2c.txt > b/Documentation/devicetree/bindings/input/hid-over-i2c.txt > index 488edcb..e648e44 100644 > --- a/Documentation/devicetree/bindings/input/hid-over-i2c.txt > +++ b/Documentation/devicetree/bindings/input/hid-over-i2c.txt > @@ -17,6 +17,9 @@ Required properties: > - interrupt-parent: the phandle for the interrupt controller > - interrupts: interrupt line > > +Optional properties: > +- power-supply: phandle of the regulator that provides the supply voltage. This needs to be actual supplies for devices. What if a device has 2 supplies? Add a device compatible string and make this property specific to that device, then it's fine. Rob
