On 09/07/2016 03:55 AM, Srinivas Kandagatla wrote:
> This patch adds bindings for pcie phy on MSM8996.
>
> This PHY has 3 Ports, including a common block. Each port is connected
> to one root complex. Each port has dedicated reset control lines apart
> from common reset and clocks for common block.
>
> Signed-off-by: Srinivas Kandagatla <[email protected]>
> ---
> .../bindings/phy/qcom-msm8996-pcie-phy.txt | 62
> ++++++++++++++++++++++
> 1 file changed, 62 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/phy/qcom-msm8996-pcie-phy.txt
>
> diff --git a/Documentation/devicetree/bindings/phy/qcom-msm8996-pcie-phy.txt
> b/Documentation/devicetree/bindings/phy/qcom-msm8996-pcie-phy.txt
> new file mode 100644
> index 0000000..51930ed
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/qcom-msm8996-pcie-phy.txt
> @@ -0,0 +1,62 @@
> +Qualcomm msm8996 pcie PHY
> +------------------------
> +
> +Required properties:
> +- compatible: compatible list, contains "qcom,msm8996-pcie-phy".
> +- reg: offset and length of the pcie PHY register set;
> +- #phy-cells: must be one
> +- clocks: a list of phandles and clock-specifier pairs, one for each entry in
> + clock-names.
> +- clock-names: must be "cfg" for phy config clock,
> + "aux" for phy aux clock,
> + "ref_clk" for 19.2 MHz ref clk and
> + "ref_clk_src" reference clock source.
> +
> +
> +- resets: a list of phandles and reset controller specifier pairs, one for
> + each entry in reset-names.
> +- reset-names: must be "phy" for reset of pcie phy block and "common" for
> + phy common reset.
> +
> +Required properties: (Child node)
> +- reg: lane numer of the pcie phy.
> +- resets: a list of phandles and reset controller specifier pairs, one for
> + each entry in reset-names.
> +- reset-names: must be "phy" for reset of pcie phy lane.
> +
> +Example:
> +
> + pcie_phy: qcom,pciephy@34000 {
phy for node name? Or pcie-phy?
> + compatible = "qcom,msm8996-pcie-phy";
> + reg = <0x00034000 0x4000>;
> + #phy-cells = <1>;
> + clocks = <&gcc GCC_PCIE_PHY_CFG_AHB_CLK>,
> + <&gcc GCC_PCIE_PHY_AUX_CLK>,
> + <&gcc GCC_PCIE_CLKREF_CLK>,
> + <&rpmcc MSM8996_RPM_SMD_LN_BB_CLK>;
> + clock-names = "cfg", "aux", "ref_clk", "ref_clk_src";
> +
> + resets = <&gcc GCC_PCIE_PHY_BCR>,
> + <&gcc GCC_PCIE_PHY_COM_BCR>;
> + reset-names = "phy", "common";
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> + pcie_phy@0{
> + reg = <0>;
> + resets = <&gcc GCC_PCIE_0_PHY_BCR>;
> + reset-names = "phy";
> + };
Why not just have reset-names with strings like "lane0", "lane1",
"lane2" in the toplevel node?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
