On 09/06/2016 05:36 PM, John Garry wrote: > Currently the slot memory is zeroed when it is > freed and also when it is reused, like in > hisi_sas_task_prep(). Optimise by avoiding the > redundant zeroing in the free. > > Signed-off-by: John Garry <[email protected]> > --- > drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c > b/drivers/scsi/hisi_sas/hisi_sas_main.c > index 5d56576..0e48751 100644 > --- a/drivers/scsi/hisi_sas/hisi_sas_main.c > +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c > @@ -97,7 +97,7 @@ void hisi_sas_slot_task_free(struct hisi_hba *hisi_hba, > struct sas_task *task, > slot->task = NULL; > slot->port = NULL; > hisi_sas_slot_index_free(hisi_hba, slot->idx); > - memset(slot, 0, sizeof(*slot)); > + /* slot memory is fully zeroed when it is reused */ > } > EXPORT_SYMBOL_GPL(hisi_sas_slot_task_free); > > Reviewed-by: Hannes Reinecke <[email protected]>
Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage [email protected] +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
