Boris, On 16.09.2016 13:38, Boris Brezillon wrote: > ubi_eba_destroy_table() was only exported (made non-static) to let vmt > code free an EBA table if the resize operation fails in the middle > (between ubi_eba_create_table() and ubi_eba_set_table() calls). > >> I'm also not really happy with the name ubi_eba_set_table() because it does >> more the setting the table. It destroys also the old one. > > I can definitely rename the function. How about ubi_eba_replace_table().
Reads much better (to me). :-) >> >> What I'm trying to say is, when we bite the bullet and introduce lots of new >> wrapper >> functions to hide internals I want very clear and describing names for them. > > I understand and I agree. > I thought ubi_eba_set_table() was accurately describing the function > purpose: assigning an EBA table to a volume. The fact that the old > table (if any) is freed when the new one is assigned is just an > internal detail, and that should not impact the user behavior. > But I'm perfectly fine renaming this function. Thanks, //richard
