Oleg Nesterov <[EMAIL PROTECTED]> wrote:
> static void release_nbp(struct kobject *kobj)
> {
> struct net_bridge_port *p
> = container_of(kobj, struct net_bridge_port, kobj);
> +
> + dev_put(p->dev);
Does this need to be done with the mutex held? And does anything actually pay
attention to the refcount on dev? I assume not...
Should you clear p->dev->br_port before calling dev_put()?
Looks reasonable. I like it.
Acked-By: David Howells <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
