Commit-ID:  60e1c842c7ea3dd6a65660864554565cc737dd86
Gitweb:     http://git.kernel.org/tip/60e1c842c7ea3dd6a65660864554565cc737dd86
Author:     Andrew Banman <aban...@sgi.com>
AuthorDate: Wed, 21 Sep 2016 11:09:15 -0500
Committer:  Ingo Molnar <mi...@kernel.org>
CommitDate: Thu, 22 Sep 2016 11:16:13 +0200

x86/platform/uv/BAU: Convert uv_physnodeaddr() use to uv_gpa_to_offset()

The BAU driver should use the functions provided by uv_hub.h rather than
its own implementations. uv_physnodeaddr converts vaddrs to paddrs for
BAU MMR fields, but this is done better by uv_gpa_to_offset.

Signed-off-by: Andrew Banman <aban...@sgi.com>
Acked-by: Thomas Gleixner <t...@linutronix.de>
Acked-by: Mike Travis <tra...@sgi.com>
Acked-by: Dimitri Sivanich <sivan...@sgi.com>
Acked-by: Thomas Gleixner <t...@linutronix.de>
Cc: Linus Torvalds <torva...@linux-foundation.org>
Cc: Peter Zijlstra <pet...@infradead.org>
Cc: a...@linux-foundation.org
Cc: r...@sgi.com
Link: 
http://lkml.kernel.org/r/1474474161-265604-5-git-send-email-aban...@sgi.com
Signed-off-by: Ingo Molnar <mi...@kernel.org>
---
 arch/x86/include/asm/uv/uv_bau.h | 2 --
 arch/x86/platform/uv/tlb_uv.c    | 4 ++--
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/x86/include/asm/uv/uv_bau.h b/arch/x86/include/asm/uv/uv_bau.h
index cc058c6..a46f270 100644
--- a/arch/x86/include/asm/uv/uv_bau.h
+++ b/arch/x86/include/asm/uv/uv_bau.h
@@ -55,8 +55,6 @@
 #define UV_BAU_TUNABLES_DIR            "sgi_uv"
 #define UV_BAU_TUNABLES_FILE           "bau_tunables"
 #define WHITESPACE                     " \t\n"
-#define uv_mmask                       ((1UL << uv_hub_info->m_val) - 1)
-#define uv_physnodeaddr(x)             ((__pa((unsigned long)(x)) & uv_mmask))
 #define cpubit_isset(cpu, bau_local_cpumask) \
        test_bit((cpu), (bau_local_cpumask).bits)
 
diff --git a/arch/x86/platform/uv/tlb_uv.c b/arch/x86/platform/uv/tlb_uv.c
index f6bc43b..34b2a48 100644
--- a/arch/x86/platform/uv/tlb_uv.c
+++ b/arch/x86/platform/uv/tlb_uv.c
@@ -1812,8 +1812,8 @@ static void pq_init(int node, int pnode)
                bcp->queue_last         = pqp + (DEST_Q_SIZE - 1);
        }
 
-       first = uv_physnodeaddr(pqp);
-       last = uv_physnodeaddr(pqp + (DEST_Q_SIZE - 1));
+       first = uv_gpa_to_offset(uv_gpa(pqp));
+       last = uv_gpa_to_offset(uv_gpa(pqp + (DEST_Q_SIZE - 1)));
        tail = first;
        gnode = uv_gpa_to_gnode(uv_gpa(pqp));
        first = (gnode << UV_PAYLOADQ_GNODE_SHIFT) | tail;

Reply via email to