On Fri, Sep 23, 2016 at 10:11:12AM +0300, Nikita Yushchenko wrote: > This patch makes it possible to use simple-card in setups where separate > amplifier chip is connected to codec's output. > > Changes from v1: > - moved example usage from commit message to Documentation/, as > suggested by Kuninori Morimoto, > - fixed typo in example usage.
Ah, one more property to the "simple" card. At what point in adding properties is it not simple? > > Signed-off-by: Nikita Yushchenko <nikita.yo...@cogentembedded.com> > --- > .../devicetree/bindings/sound/simple-card.txt | 37 > ++++++++++++++++++++++ > sound/soc/generic/simple-card.c | 34 ++++++++++++++++++++ > 2 files changed, 71 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/simple-card.txt > b/Documentation/devicetree/bindings/sound/simple-card.txt > index 59d8628..c7a9393 100644 > --- a/Documentation/devicetree/bindings/sound/simple-card.txt > +++ b/Documentation/devicetree/bindings/sound/simple-card.txt > @@ -22,6 +22,8 @@ Optional properties: > headphones are attached. > - simple-audio-card,mic-det-gpio : Reference to GPIO that signals when > a microphone is attached. > +- simple-audio-card,aux-devs : List of phandles pointing to > auxiliary devices, such > + as amplifiers, to be added to the > sound card. I think the property should be specific as to the type of device. What if you have 2 amps? Maybe simple-card can't have 2 outputs. What if you have a chain of devices and need to know the order of them? Rob
