On Sat, 2016-09-24 at 15:50 +0200, SF Markus Elfring wrote:
> * Prefer usage of the macro "pr_info" over the interface "printk"
> in this function.
> * Reduce number of output function calls.
Did you test this? I doubt it.
> diff --git a/drivers/input/joystick/joydump.c
> b/drivers/input/joystick/joydump.c
[]
> @@ -57,27 +57,29 @@ static int joydump_connect(struct gameport *gameport,
> struct gameport_driver *dr
> > unsigned long flags;
> > unsigned char u;
>
> > - printk(KERN_INFO "joydump: ,------------------ START
> > ----------------.\n");
> > - printk(KERN_INFO "joydump: | Dumping: %30s |\n", gameport->phys);
> > - printk(KERN_INFO "joydump: | Speed: %28d kHz |\n", gameport->speed);
> > + pr_info(",------------------ START ----------------.\n"
> > + "| Dumping: %30s |\n"
> > + "| Speed: %28d kHz |\n",
> > + gameport->phys,
> > + gameport->speed);
Not the same output.
