On Wed, Sep 14, 2016 at 10:37:05AM +0200, Miklos Szeredi wrote: > This contains assorted cleanups in the splice area: > > - add helpers for pipe buf ops instead of directly calling them > > - page cache buf doesn't seem to need confirming (since ages) > > - generic_file_splice_read() and generic_file_read() have lots of > duplication > > Git tree is here: > > git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git#splice
My apologies for not replying back when it had been first posted, especially since I'd been actively messing with splice-related code at that time (it started in "xfs_file_splice_read: possible circular locking dependency detected" thread on xfs list). I've no objections against your inline helpers. I'm not so sure about ->confirm() and I really think that __generic_file_splice_read() should simply die. Could you rebase the beginning of that thing on top of #work.splice_read in vfs.git?
