On Thu, 2016-09-29 at 13:56 -0700, Joe Perches wrote: > It doesn't matter match either way to me. > > The case for the unnecessary multiply with <= gcc 4.8 was > removed with: > > commit 91c6a05f72a996bee5133e76374ab3ad7d3b9b72 > Author: Alexey Dobriyan <adobri...@gmail.com> > Date: Tue Jul 26 15:22:08 2016 -0700 > > mm: faster kmalloc_array(), kcalloc() > > When both arguments to kmalloc_array() or kcalloc() are known at compile > time then their product is known at compile time but search for kmalloc > cache happens at runtime not at compile time. > > Link: http://lkml.kernel.org/r/20160627213454.ga2...@p183.telecom.by > Signed-off-by: Alexey Dobriyan <adobri...@gmail.com> > Cc: Christoph Lameter <c...@linux.com> > Cc: Pekka Enberg <penb...@kernel.org> > Cc: David Rientjes <rient...@google.com> > Cc: Joonsoo Kim <iamjoonsoo....@lge.com> > Signed-off-by: Andrew Morton <a...@linux-foundation.org> > Signed-off-by: Linus Torvalds <torva...@linux-foundation.org>
You've lost me. Why does this stop you fixing an apparently wrong checkpatch rule, crude as parts of it are (ie, uppercase identifier must be a constant)? Paul Bolle
