On Thursday 22 February 2007 16:29, Adrian Bunk wrote: > On Wed, Feb 21, 2007 at 11:00:15AM +0100, Giuseppe Bilotta wrote: > > On Wednesday 21 February 2007 02:49, Greg KH wrote: > > > > > /* frame pointer must be last for get_wchan */ > > > -#define SAVE_CONTEXT "pushq %%rbp ; movq %%rsi,%%rbp\n\t" > > > -#define RESTORE_CONTEXT "movq %%rbp,%%rsi ; popq %%rbp\n\t" > > > +#define SAVE_CONTEXT "pushf ; pushq %%rbp ; movq %%rsi,%%rbp\n\t" > > > +#define RESTORE_CONTEXT "movq %%rbp,%%rsi ; popq %%rbp ; popf\t" > > > > No idea if this is a problem or not, but you forgot a \n after popf. > > A discussion of this issue is in the thread starting with [1] > (and I'd re-add the \n in -stable kernels with the patch below > (stolen from 2.6.16) no matter what happened in Linus' tree).
The newline only helps some broken out of tree patches (which I won't name here) that shouldn't touch this anyways. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/