On Fri, Oct 7, 2016 at 9:17 PM, Bacchewar, Nilesh <[email protected]> wrote: > Here, Its marking GPIO controller IRQ line as wake capable not GPIO lines.
AFAIU this is called per (GPIO) pin which is IRQ enabled. Imagine a case when you have more than one such pin. 1. Set IRQ wake for pin 1 2. Set IRQ wake for pin 2 (assume that is pin under the question) 3. Unset IRQ wake for pin 1 (for some reason) 4. Global pinctrl IRQ wake is unset. Resulting same issue as before. What did I miss above? > > Regards, > Nilesh > > -----Original Message----- > From: Andy Shevchenko [mailto:[email protected]] > Sent: Friday, October 7, 2016 10:59 AM > To: Bacchewar, Nilesh <[email protected]> > Cc: Mika Westerberg <[email protected]>; Krogerus, Heikki > <[email protected]>; Linus Walleij <[email protected]>; > [email protected]; [email protected] > Subject: Re: [PATCH] pinctrl: intel: Configure GPIO chip IRQ as wakeup > interrupts > > On Thu, Sep 22, 2016 at 2:03 AM, Nilesh Bacchewar > <[email protected]> wrote: >> On some Intel BXT platform, wake-up from suspend-to-idle on pressing >> power-button is not working. Its noticed that gpio-keys driver marking >> the second level IRQ/power-button as wake capable but Intel pintctrl >> driver is missing to mark GPIO chip/controller IRQ which first level >> IRQ as wake cable if its GPIO pin IRQ is wakeble. So, though the first >> level IRQ gets generated on power-button press, since it is not marked >> as wake capable resume/wake-up flow is not happening. >> Intel pintctrl/GPIO driver need to mark GPIO chip/controller IRQ >> (first level IRQ) as wake capable iff GPIO pin's IRQ (second level >> IRQ) is marked as wake cable. > >> if (on) >> - gpe_en |= BIT(gpp_offset); >> + enable_irq_wake(pctrl->irq); >> else >> - gpe_en &= ~BIT(gpp_offset); >> - writel(gpe_en, community->regs + GPI_GPE_EN + gpp * 4); >> - >> - raw_spin_unlock_irqrestore(&pctrl->lock, flags); >> + disable_irq_wake(pctrl->irq); > > Shouldn't be refcounting here or I missed something? > What I think of is 2+ GPIO lines marked as wake capable IRQ sources and one > of them is disabled earlier by some reason. > > -- > With Best Regards, > Andy Shevchenko -- With Best Regards, Andy Shevchenko
