On Thu, 22 Feb 2007 11:43:38 +0100, Duncan Sands <[EMAIL PROTECTED]> wrote:
> > + /* the module/device has probably been removed */ > > + if (urb->status == -ESHUTDOWN) > > + return; > > + > > if (printk_ratelimit()) > > atm_warn(channel->usbatm, "%s: urb 0x%p failed (%d)!\n", > > __func__, urb, urb->status); > > I would rather just suppress the warning in this case, and still do the > delayed > schedule of the tasklet, in case this error was spurious and we're not really > about to be disconnected. I disagree. If ESHUTDOWN is received, the endpoint is definitely gone. I can see why you might want to retry EPROTO, ELISEQ, etc. but this case is different. -- Pete - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
