On 11 October 2016 at 22:38, Viresh Kumar <viresh.ku...@linaro.org> wrote: > On 07-10-16, 16:21, Markus Mayer wrote: >> +static int brcm_avs_cpufreq_exit(struct cpufreq_policy *policy) >> +{ >> + struct private_data *priv = policy->driver_data; >> + >> + iounmap(priv->base); >> + iounmap(priv->avs_intr_base); >> + >> + return 0; >> +} > > Shouldn't the above be done in the below routine instead ?
Good point. I'll move it. >> +static int brcm_avs_cpufreq_remove(struct platform_device *pdev) >> +{ >> + platform_set_drvdata(pdev, NULL); >> + >> + return cpufreq_unregister_driver(&brcm_avs_driver); >> +} > > -- > viresh