On Sat, 24 Feb 2007 10:41:15 +0300, Cyrill Gorcunov <[EMAIL PROTECTED]> wrote:
> Thanks a lot for comments and Ack the patch please.
Cyrill, I forgot to mention a couple of points, sorry.
> printk(KERN_INFO "driver %s built at %s on %s\n",
> ftdi_elan_driver.name,
> - __TIME__, __DATE__);
> + __TIME__, __DATE__);
Is this really necessary?
> respond_queue = create_singlethread_workqueue("ftdi-respond-engine");
> + if (!respond_queue)
> + goto err3;
This is good, but...
> result = usb_register(&ftdi_elan_driver);
> if (result)
> printk(KERN_ERR "usb_register failed. Error number %d\n",
> - result);
> + result);
> return result;
What does happen if usb_register fails? Since you fixed the
create_singlethread_workqueue, why not this too?
-- Pete
cc: to [EMAIL PROTECTED] and linux-usb-devel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
