On Fri, 2016-10-21 at 14:56 +0200, Jiri Kosina wrote: > On Fri, 21 Oct 2016, Eric Dumazet wrote: > > > Some of us are dealing with huge HTB hierarchies, so adding default fifo > > in the dump will add more data pumped from the kernel. > > > > BwE [1] for instance dumps qdisc/classes every 5 seconds. > > > > I guess we'll need to not pull this patch in our kernels. > > Okay, so I probably misunderstood you here: > > https://marc.info/?l=linux-kernel&m=146073234818214&w=2 > > as I thought that as long as we move towards the hashtable, you wouldn't > have any issues with this. > > I'd really like to unhide the default qdiscs, it makes little sense to be > inconsistent in this way. > > Random shot into darkness -- how about making this a > CONFIG/sysctl-selectable?
Oh sorry for the confusion, I believe your patch is fine. We could add an netlink attribute later for the users that really do not want default fifo being dumped, but there is no hurry. Acked-by: Eric Dumazet <eduma...@google.com>
