On Oct 20 Jarod Wilson wrote: > firewire-net: > - set min/max_mtu > - remove fwnet_change_mtu [...] > --- a/drivers/firewire/net.c > +++ b/drivers/firewire/net.c [...] > @@ -1478,9 +1467,10 @@ static int fwnet_probe(struct fw_unit *unit, > * Use the RFC 2734 default 1500 octets or the maximum payload > * as initial MTU > */ > - max_mtu = (1 << (card->max_receive + 1)) > - - sizeof(struct rfc2734_header) - IEEE1394_GASP_HDR_SIZE; > - net->mtu = min(1500U, max_mtu); > + net->max_mtu = (1 << (card->max_receive + 1)) > + - sizeof(struct rfc2734_header) - IEEE1394_GASP_HDR_SIZE; > + net->mtu = min(1500U, net->max_mtu); > + net->min_mtu = ETH_MIN_MTU; > > /* Set our hardware address while we're at it */ > ha = (union fwnet_hwaddr *)net->dev_addr;
Please preserve the current behavior, i.e. do not enforce any particular upper bound. (Especially none based on the local link layer controller's max_receive parameter.) BTW, after having read RFC 2734, RFC 3146, and the code, I am convinced that net->mtu should be initialized to 1500, not less. But such a change should be done in a separate patch. -- Stefan Richter -======----- =-=- =-==- http://arcgraph.de/sr/
