Commit 0eadf37afc250 ("nbd: allow block mq to deal with timeouts") changed normal usage of nbd->sock_lock to use spin_lock/spin_unlock rather than the *_irq variants, but it missed this unlock in an error path.
Found by Coverity, CID 1373871. Signed-off-by: John W. Linville <linvi...@tuxdriver.com> Cc: Josef Bacik <jba...@fb.com> Cc: Jens Axboe <ax...@fb.com> Cc: Markus Pargmann <m...@pengutronix.de> Fixes: 0eadf37afc250 ("nbd: allow block mq to deal with timeouts") --- By inspection (i.e. compile tested only)... drivers/block/nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index ba405b55329f..19a16b2dbb91 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -164,7 +164,7 @@ static void sock_shutdown(struct nbd_device *nbd) spin_lock(&nbd->sock_lock); if (!nbd->sock) { - spin_unlock_irq(&nbd->sock_lock); + spin_unlock(&nbd->sock_lock); return; } -- 2.7.4