On 10/22, Xiaolong Zhang wrote: > On ε, 10ζ 20, 2016 at 04:01:03δΈε -0700, Stephen Boyd wrote: > > On 10/11, Orson Zhai wrote: > > > From: Xiaolong Zhang <xiaolong.zh...@spreadtrum.com> > > > > > > When common kernel setups fixed clock, of_clk_provider will be > > > registerred. > > > But there is no clkdev being registerred at the same time. This will make > > > it difficult to get the clock by using clk_get(NULL, con_id). > > > > > > Add clkdev register for fixed-rate and fixed-factor clock and ignore > > > the error if any. > > > > > > Signed-off-by: Xiaolong Zhang <xiaolong.zh...@spreadtrum.com> > > > Signed-off-by: Orson Zhai <orson.z...@spreadtrum.com> > > > --- > > > > Why are we using clkdev lookups for clks populated from DT? > > Shouldn't we be able to point to them from the consumers that > > would also be in DT? I'm a little lost. > > > The clk_get interface allows the first argument as NULL. We just assure > consumers can get the clock from DT or by clock name.
Ok. The first argument to clk_get() really shouldn't be NULL. It should be the device pointer for the device that is associated with the clk you want to get. The clock name (second argument to clk_get()) should be device specific and not some globally unique identifier. It seems that you're using the clk_get() API incorrectly. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
