On Wed, 26 Oct 2016, Fenghua Yu wrote:
> On Wed, Oct 26, 2016 at 03:02:56PM +0200, Thomas Gleixner wrote:
> > > + list_for_each(l, &r->domains) {
> > > + d = list_entry(l, struct rdt_domain, list);
> >
> > So above you converted to list_for_each_entry(). Is there a sensible
> > reason, aside of being sloppy, why is this still using list_for_each()?
>
> We use list_for_each() because we want to get the list_head "l". The l
> is used to find the position that the new domain will be inserted.
Sorry. I completely missed that position information thingy. No change
required then.
> The following patch #10 is supposed to fix issues you pointed out above.
>
> Is it good now?
Looks fine.
Thanks,
tglx
