On Thu, Oct 27, 2016 at 1:25 PM, Frank Rowand <frowand.l...@gmail.com> wrote: > On 10/27/16 09:58, Rob Herring wrote: >> On Thu, Oct 27, 2016 at 11:35 AM, Frank Rowand <frowand.l...@gmail.com> >> wrote: >>> On 10/27/16 05:47, Rob Herring wrote: >>>> On Tue, Oct 25, 2016 at 3:58 PM, <frowand.l...@gmail.com> wrote: >>>>> From: Frank Rowand <frank.row...@am.sony.com> >>>> >>>> I prefer to leave the prefixes and this is getting into pointless churn. >>>> >>>>> >>>>> Signed-off-by: Frank Rowand <frank.row...@am.sony.com> >>>>> --- >>>>> drivers/of/resolver.c | 10 +++++----- >>>>> 1 file changed, 5 insertions(+), 5 deletions(-) >>>> >>> >>> If I was just submitting this as a single patch, I would agree. >>> >>> But since I am making so many other changes, I think it makes >>> sense to do this as part of this series. It is broken apart >>> as a separate patch to be easy to review and not pollute any >>> of the other patches in the series. >>> >>> The prefixes add no value for a local function, but they do >>> add noise when reading code. >> >> The value is when reading the calling function, you know the function >> is a DT related function. You don't know it's a static function > > It is more than that. A common convention in drivers/of/ is that > function blah() acquires a lock, calls function __blah(), and > releases the lock. Any function other than blah() that wants > to call __blah() must also hold the proper lock. The functions > whose name this patch changes do not fit this pattern.
Okay, fair enough. Rob
