From: Wei Yongjun <weiyongj...@huawei.com>

In case of error, the function st_slim_rproc_alloc() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <weiyongj...@huawei.com>
Acked-by: Peter Griffin <peter.grif...@linaro.org>
---
 drivers/dma/st_fdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/st_fdma.c b/drivers/dma/st_fdma.c
index 232d354..bfb79bd 100644
--- a/drivers/dma/st_fdma.c
+++ b/drivers/dma/st_fdma.c
@@ -792,7 +792,7 @@ static int st_fdma_probe(struct platform_device *pdev)
        }
 
        fdev->slim_rproc = st_slim_rproc_alloc(pdev, fdev->fw_name);
-       if (!fdev->slim_rproc) {
+       if (IS_ERR(fdev->slim_rproc)) {
                ret = PTR_ERR(fdev->slim_rproc);
                dev_err(&pdev->dev, "slim_rproc_alloc failed (%d)\n", ret);
                goto err;
-- 
2.7.4

Reply via email to