On Tue, Nov 08, 2016 at 04:08:44PM -0800, Gayatri Kammela wrote: > Modify cpufeatures.h to add new AVX512 instruction groups/features > for enuermation in /proc/cpuinfo: AVX512IFMA and AVX512VBMI > > Also modify the xstate.c to clear the flags in > fpu__xstate_clear_all_cpu_caps().
This is already visible in the diff itself, no need to explain what the patch does. Also, please run your commit message through a spellchecker. > CPUID.(EAX=7,ECX=0):EBX[bit 21] AVX512IFMA > CPUID.(Eax=7,ECX=0):ECX[bit 1] AVX512VBMI s/Eax/EAX/ > Detailed information of cpuid bits for the features can be found in > Intel Architecture Instruction Set Extensions Programming Reference. We have recently started uploading such documents into bugzilla.kernel.org in order to have a stable reference source, see https://lkml.kernel.org/r/alpine.DEB.2.20.1611082002160.3501@nanos Please do so too and add the link to the commit message. Rest looks ok to me. Thanks. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.