> it seems broken to manipulate xfer_mask after returning from the > driver's ->mode_filter hook. > > this patch is more than just a speed-limited warning printk, afaics
I actually suggested that order because the only way the printk can be done correctly is for it to be the very last test made. Since the mode filter is not told what mode will be used but just subtracts modes that are not allowed this should be safe. I don't otherwise see how we deal with the case where a 40wire cable is used and the mode filter function decides itself to drop to UDMA33 or lower due to incompatibilities or errata. Alan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
