On Thu 1 Mar 2007 10:52, Stephen Hemminger pondered: > Wu, Bryan wrote: > > Hi folks, > > > > Here is the blackfin on-chip ethernet MAC controller driver for Linux. > > > > Index: linux-2.6/drivers/net/Kconfig > > =================================================================== > > --- linux-2.6.orig/drivers/net/Kconfig 2007-03-01 11:39:14.000000000 > > +0800 +++ linux-2.6/drivers/net/Kconfig 2007-03-01 11:39:19.000000000 > > +0800 @@ -836,6 +836,50 @@ > > module, say M here and read <file:Documentation/modules.txt> as well > > as <file:Documentation/networking/net-modules.txt>. > > > > +config BFIN_MAC > > + tristate "Blackfin 536/537 on-chip mac support" > > + depends on NET_ETHERNET && (BF537 || BF536) && (!BF537_PORT_H) > > + select CRC32 > > + select BFIN_MAC_USE_L1 if DMA_UNCACHED_NONE > > + help > > + This is the driver for blackfin on-chip mac device. Say Y if you want > > it + compiled into the kernel. This driver is also available as a > > module + ( = code which can be inserted in and removed from the running > > kernel + whenever you want). The module will be called bfin_mac. > > + > > +config BFIN_MAC_USE_L1 > > + bool "Use L1 memory for rx/tx packets" > > + depends on BFIN_MAC && BF537 > > + default y > > + help > > + To get maximum network performace, you should use L1 memory as rx/tx > > buffers. + Say N here if you want to reserve L1 memory for other uses. > > + > > +config BFIN_TX_DESC_NUM > > + int "Number of transmit buffer packets" > > + depends on BFIN_MAC > > + range 6 10 if BFIN_MAC_USE_L1 > > + range 10 100 > > + default "10" > > + help > > + Set the number of buffer packets used in driver. > > + > > +config BFIN_RX_DESC_NUM > > + int "Number of receive buffer packets" > > + depends on BFIN_MAC > > + range 20 100 if BFIN_MAC_USE_L1 > > + range 20 800 > > + default "20" > > + help > > + Set the number of buffer packets used in driver > > The regular practice is to put these in a device include file, and not > make them kernel configurable. > Why would you want to make it tuneable at compile time?
It is to attempt to make it easier for our end users to configure&use. Most people who use it, want to make some tweaks to the configuration based on their embedded platform. Rather than forcing everyone to make changes to a .c or .h file, we let them manage it in the .config (which is platforms specific anyway). -Robin - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
