On 11/16/2016 11:50 PM, Luis Henriques wrote: > This patch was triggered by the following Coccinelle error: > > ./drivers/mtd/maps/sc520cdp.c:246:3-9: \ > ERROR: missing iounmap; ioremap on line 242 \ > and execution via conditional on line 244 > > Signed-off-by: Luis Henriques <[email protected]>
Reviewed-by: Marek Vasut <[email protected]> > --- > drivers/mtd/maps/sc520cdp.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/mtd/maps/sc520cdp.c b/drivers/mtd/maps/sc520cdp.c > index 093edd51bdc7..7a27ed345d0d 100644 > --- a/drivers/mtd/maps/sc520cdp.c > +++ b/drivers/mtd/maps/sc520cdp.c > @@ -243,6 +243,10 @@ static int __init init_sc520cdp(void) > > if (!sc520cdp_map[i].virt) { > printk("Failed to ioremap_nocache\n"); > + if (i) { > + while (--i) > + iounmap(sc520cdp_map[i].virt); > + } > return -EIO; > } > > -- Best regards, Marek Vasut
