On Fri, 18 Nov 2016, Tan Jui Nee wrote:
> Adding Intel codename Apollo Lake platform device IDs for PCH.
>
> Signed-off-by: Tan Jui Nee <jui.nee....@intel.com>
> Acked-for-MFD-by: Lee Jones <lee.jo...@linaro.org>
> ---
> Changes in V11:
> - No change
>
> Changes in V10:
> - No change
>
> Changes in V9:
> - No change
>
> Changes in V8:
> - No change
>
> drivers/mfd/lpc_ich_core.c | 6 ++++++
> include/linux/mfd/lpc_ich.h | 1 +
> 2 files changed, 7 insertions(+)
>
> diff --git a/drivers/mfd/lpc_ich_core.c b/drivers/mfd/lpc_ich_core.c
> index 920198a..3bb6334 100644
> --- a/drivers/mfd/lpc_ich_core.c
> +++ b/drivers/mfd/lpc_ich_core.c
> @@ -54,6 +54,7 @@
> * document number TBD : Wildcat Point-LP
> * document number TBD : 9 Series
> * document number TBD : Lewisburg
> + * document number TBD : Apollo Lake
When exactly are you guys going to start filling in these TBD document
numbers? Most of these entries are >4 years old!
I suggest you either start populating them, or remove the reference.
Besides that:
For my own reference:
Acked-for-MFD-by: Lee Jones <lee.jo...@linaro.org>
> */
>
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> @@ -458,6 +459,10 @@ struct lpc_ich_priv {
> .name = "9 Series",
> .iTCO_version = 2,
> },
> + [LPC_APL] = {
> + .name = "Apollo Lake SoC",
> + .iTCO_version = 5,
> + },
> };
>
> /*
> @@ -606,6 +611,7 @@ struct lpc_ich_priv {
> { PCI_VDEVICE(INTEL, 0x3b14), LPC_3420},
> { PCI_VDEVICE(INTEL, 0x3b16), LPC_3450},
> { PCI_VDEVICE(INTEL, 0x5031), LPC_EP80579},
> + { PCI_VDEVICE(INTEL, 0x5ae8), LPC_APL},
> { PCI_VDEVICE(INTEL, 0x8c40), LPC_LPT},
> { PCI_VDEVICE(INTEL, 0x8c41), LPC_LPT},
> { PCI_VDEVICE(INTEL, 0x8c42), LPC_LPT},
> diff --git a/include/linux/mfd/lpc_ich.h b/include/linux/mfd/lpc_ich.h
> index 42307ee..397008c 100644
> --- a/include/linux/mfd/lpc_ich.h
> +++ b/include/linux/mfd/lpc_ich.h
> @@ -112,6 +112,7 @@ enum lpc_chipsets {
> LPC_BRASWELL, /* Braswell SoC */
> LPC_LEWISBURG, /* Lewisburg */
> LPC_9S, /* 9 Series */
> + LPC_APL, /* Apollo Lake SoC */
> };
>
> #endif
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
